[Data] Don't drop first dataset when peeking DatasetPipeline
#31513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
amogkam
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
amogkam
commented
Jan 7, 2023
jianoaix
reviewed
Jan 9, 2023
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
|
Thanks @jianoaix! Regarding
I updated the PR to add this back to retain old behavior. The cached peeked dataset will be used whenever possible, unless new transformations are applied. |
Signed-off-by: amogkam <[email protected]>
jianoaix
approved these changes
Jan 9, 2023
| # We re-use the saved _first_dataset and _remaining_dataset_iter | ||
| if self._first_dataset is not None: | ||
|
|
||
| class _IterableWrapper(Iterable): |
There was a problem hiding this comment.
Is this wrapping needed since iterator itself has iter to return itself?
|
Need to tweak this PR a bit...cannot create new Pipelines since the stats are not carried over to the current pipeline. |
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
jianoaix
added
the
@author-action-required
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
jianoaix
reviewed
Jan 12, 2023
Signed-off-by: amogkam <[email protected]>
jianoaix
approved these changes
Jan 13, 2023
…-schema-map-batches
…-schema-map-batches
|
Failing test is also failing on master...going to merge. |
amogkam
removed
the
@author-action-required
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
…roject#31513) Signed-off-by: amogkam [email protected] Closes ray-project#31505. When peeking a DatasetPipeline via .schema() for example, the first dataset in the base iterator is consumed. Then when chaining new operations on the pipeline, such as a map_batches, the dataset that was peeked is lost. In this PR, we change the implementation of peek to not consume the base iterable, but rather create a new iterable consisting of just the first dataset. Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: amogkam [email protected]
Closes #31505.
When peeking a
DatasetPipelinevia.schema()for example, the first dataset in the base iterator is consumed. Then when chaining new operations on the pipeline, such as amap_batches, the dataset that was peeked is lost.In this PR, we change the implementation of peek to not consume the base iterable, but rather create a new iterable consisting of just the first dataset.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.