Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Final polish batch_tuning and batch_forecasting examples #31578

Merged
merged 17 commits into from
Mar 16, 2023
Merged

[Docs] Final polish batch_tuning and batch_forecasting examples #31578

merged 17 commits into from
Mar 16, 2023

Conversation

christy
Copy link
Contributor

@christy christy commented Jan 11, 2023 •
edited
Loading

Signed-off-by: Christy Bergman [email protected]

Why are these changes needed?

Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

  • Update notebook texts, make steps clearer.
  • Tune outputs only showing SMOKE_TEST outputs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

christy and others added 2 commits January 10, 2023 17:25
Yard1
Yard1 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

doc/source/ray-air/examples/batch_tuning.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/batch_tuning.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/batch_tuning.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/batch_tuning.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/batch_forecasting.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/batch_forecasting.ipynb Show resolved Hide resolved
doc/source/ray-air/examples/batch_forecasting.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/batch_forecasting.ipynb Outdated Show resolved Hide resolved
christy and others added 8 commits January 12, 2023 17:50
@christy @Yard1
Update doc/source/ray-air/examples/batch_tuning.ipynb
206b61e 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy @Yard1
Update doc/source/ray-air/examples/batch_tuning.ipynb
e4c059b 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy @Yard1
Update doc/source/ray-air/examples/batch_tuning.ipynb
ab9d02c 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy @Yard1
Update doc/source/ray-air/examples/batch_tuning.ipynb
a7c227b 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy @Yard1
Update doc/source/ray-air/examples/batch_forecasting.ipynb
6366864 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy @Yard1
Update doc/source/ray-air/examples/batch_forecasting.ipynb
042a386 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy @Yard1
Update doc/source/ray-air/examples/batch_forecasting.ipynb
b5288e6 
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Christy Bergman <[email protected]>
@christy
Update batch_forecasting.ipynb
c51aeac 
Apply same suggested edits to notebook text to both files.

Signed-off-by: Christy Bergman <[email protected]>
@stale
Copy link

stale bot commented Feb 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 12, 2023
@Yard1 Yard1 removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 12, 2023
@stale
Copy link

stale bot commented Mar 14, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 14, 2023
@Yard1 Yard1 removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 15, 2023
@Yard1 Yard1 self-assigned this Mar 16, 2023
@Yard1
Use references
73e1a31 
Signed-off-by: Antoni Baum <[email protected]>
@Yard1
Fix
6fe381e 
Signed-off-by: Antoni Baum <[email protected]>
@Yard1 Yard1 merged commit 5651256 into master Mar 16, 2023
@Yard1 Yard1 deleted the christy-docs branch March 16, 2023 23:44
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@christy @Yard1 @ProjectsByJackHe
[Docs] Final polish batch_tuning and batch_forecasting examples (ray-…
fa805a9 
…project#31578)

Why are these changes needed?
Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

Update notebook texts, make steps clearer.
Tune outputs only showing SMOKE_TEST outputs.

---------

Signed-off-by: Christy Bergman <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Jack He <[email protected]>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@christy @Yard1 @edoakes
[Docs] Final polish batch_tuning and batch_forecasting examples (ray-…
4ecf306 
…project#31578)

Why are these changes needed?
Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

Update notebook texts, make steps clearer.
Tune outputs only showing SMOKE_TEST outputs.

---------

Signed-off-by: Christy Bergman <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@christy @Yard1 @peytondmurray
[Docs] Final polish batch_tuning and batch_forecasting examples (ray-…
f4cbd4b 
…project#31578)

Why are these changes needed?
Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

Update notebook texts, make steps clearer.
Tune outputs only showing SMOKE_TEST outputs.

---------

Signed-off-by: Christy Bergman <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Co-authored-by: Antoni Baum <[email protected]>
chaowanggg pushed a commit to chaowanggg/ray-dev that referenced this pull request Apr 4, 2023
@christy @Yard1 @chaowanggg
[Docs] Final polish batch_tuning and batch_forecasting examples (ray-…
b6c43be 
…project#31578)

Why are these changes needed?
Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

Update notebook texts, make steps clearer.
Tune outputs only showing SMOKE_TEST outputs.

---------

Signed-off-by: Christy Bergman <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: chaowang <[email protected]>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@christy @Yard1 @elliottower
[Docs] Final polish batch_tuning and batch_forecasting examples (ray-…
109198d 
…project#31578)

Why are these changes needed?
Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

Update notebook texts, make steps clearer.
Tune outputs only showing SMOKE_TEST outputs.

---------

Signed-off-by: Christy Bergman <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@christy @Yard1 @ProjectsByJackHe
[Docs] Final polish batch_tuning and batch_forecasting examples (ray-…
fb27abe 
…project#31578)

Why are these changes needed?
Changes made to batch_tuning.ipynb and batch_forecasting.ipynb:

Update notebook texts, make steps clearer.
Tune outputs only showing SMOKE_TEST outputs.

---------

Signed-off-by: Christy Bergman <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Co-authored-by: Antoni Baum <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@gjoliver gjoliver Awaiting requested review from gjoliver

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christy @Yard1