-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Change Gradio integration to take a builder function to avoid serialization issues #31619
Conversation
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
The fix looks good to me. General question: does it mean we will not support Gradio 3.5 in this case? |
No, earlier versions should still be supported. We are just sidestepping the serialization issue by changing the API of our integration - functionality is still the same, the Gradio object is just built remotely on the cluster instead of locally to avoid serialization. |
Test |
|
sorry, click wrong button.... |
… serialization issues (ray-project#31619) New versions of Gradio make Gradio objects un-serializable in Ray. This makes it impossible to directly pass in a Gradio object to `GradioIngress`, so to avoid this the API is changed to accept a builder function that constructs the Gradio object on the Ray cluster. Signed-off-by: Andrea Pisoni <[email protected]>
Signed-off-by: Cindy Zhang [email protected]
Why are these changes needed?
New versions of Gradio make Gradio objects un-serializable in Ray. This makes it impossible to directly pass in a Gradio object to
GradioIngress
, so to avoid this the API is changed to accept a builder function that constructs the Gradio object on the Ray cluster.Related issue number
Closes #31161
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.