Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Update WandbLoggerCallback example #31625

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jan 12, 2023

Signed-off-by: Balaji Veeramani [email protected]

Why are these changes needed?

The WandbLoggerCallback isn't tested, and it uses outdated APIs (tune.run instead of Tuner.fit). This PR updates the example so it's tested and uses recommended APIs.

Related issue number

Closes #31217

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one question for testing

.buildkite/pipeline.build.yml Outdated Show resolved Hide resolved
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@krfricke krfricke merged commit 0018ddb into ray-project:master Jan 19, 2023
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
The `WandbLoggerCallback` isn't tested, and it uses outdated APIs (`tune.run` instead of `Tuner.fit`). This PR updates the example so it's tested and uses recommended APIs.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR] Add docstring example of WandbLoggerCallback
2 participants