[Datasets] Handle np.array(dtype=object) constructor for ragged ndarrays
#31670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <[email protected]>
scottjlee
requested review from
clarkzinzow,
jiaodong,
Yard1,
bveeramani,
matthewdeng,
amogkam,
ericl,
scv119,
jjyao,
jianoaix and
c21
as code owners
Signed-off-by: Scott Lee <[email protected]>
|
@scottjlee - could you point out which code change in this PR is newly added, compared to previous committed PR? |
scottjlee
commented
Jan 13, 2023
|
|
||
| import numpy as np | ||
|
|
||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
This is the new section added in this PR. The rest of the code changes are exactly the same as from the previous PR
Thanks for the reminder, just added a comment in the new section of code. |
clarkzinzow
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Lee [email protected]
Why are these changes needed?
This is a rework of #31544, which was reverted because of broken CI tests (bad
pandasimport). We replicate the aforementioned PR, with an additionalTYPE_CHECKINGusage to only import frompandaswhen type-checking.Related issue number
Rework of PR #31544
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.