Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] Add Vim sessions to gitignore #31711

Merged
merged 1 commit into from
Jan 18, 2023
Merged

[Dev] Add Vim sessions to gitignore #31711

merged 1 commit into from
Jan 18, 2023

Conversation

clarkzinzow
Copy link
Contributor

This PR ensures that git ignores Vim sessions, which we don't want to commit.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarkzinzow
Add Vim sessions to gitignore
cd377fe 
Signed-off-by: Clark Zinzow <[email protected]>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 18, 2023
@clarkzinzow clarkzinzow merged commit 7e7f376 into master Jan 18, 2023
@clarkzinzow clarkzinzow deleted the dev/feat/ignore-vim-sessions branch January 18, 2023 01:01
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
@clarkzinzow @andreapiso
Add Vim sessions to gitignore (ray-project#31711)
f025fd1 
This PR ensures that git ignores Vim sessions, which we don't want to commit.

Signed-off-by: Clark Zinzow <[email protected]>
Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

@richardliaw richardliaw

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarkzinzow @ericl @richardliaw