[AIR] Add set_preprocessor method to Checkpoint
#31721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
amogkam
requested review from
richardliaw,
gjoliver,
krfricke,
xwjiang2010,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
amogkam
changed the title
set_checkpoint to Checkpointset_checkpoint method to Checkpoint
7 tasks
bveeramani
reviewed
Jan 18, 2023
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
|
Sorry, do you mean |
amogkam
changed the title
set_checkpoint method to Checkpointset_preprocessor method to Checkpoint
|
@Yard1 yes sorry-- udpated the title |
Yard1
approved these changes
Jan 18, 2023
bveeramani
reviewed
Jan 18, 2023
|
|
||
| def testObjectRefCheckpointSetPreprocessor(self): | ||
| ckpt = Checkpoint.from_dict({"x": 1}) | ||
| ckpt = ray.get(ray.put(ckpt)) |
There was a problem hiding this comment.
I don't think this ckpt is an object ref checkpoint. When I checkedckpt._obj_ref here, I got None.
Is this what we want?
obj_ref = ray.put({"x": 1})
ckpt = Checkpoint.from_object_ref(obj_ref)
There was a problem hiding this comment.
from_object_ref is deprecated in favor of ray.get?
Seems like the _obj_ref path is not used anymore at all.
There was a problem hiding this comment.
Ah, yeah, you're right. I'll open a PR to remove the dead code.
|
Failing test is also failing on master, going to merge. |
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
Signed-off-by: amogkam [email protected] Adds a set_preprocessor method to the Checkpoint class, analogous to the existing get_checkpoint method. This is necessary to easily specify preprocessors to Checkpoints when not using any of the existing framework-specific checkpoints. Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: amogkam [email protected]
Adds a
set_preprocessormethod to theCheckpointclass, analogous to the existingget_checkpointmethod. This is necessary to easily specify preprocessors to Checkpoints when not using any of the existing framework-specific checkpoints.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.