[AIR] Use specified Preprocessor configs when using stream API.
#31725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
amogkam
changed the title
Preprocessor configs when using stream API.
amogkam
requested review from
clarkzinzow,
jiaodong,
Yard1,
bveeramani,
matthewdeng,
ericl,
scv119,
jjyao,
jianoaix and
c21
as code owners
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
stephanie-wang
approved these changes
Jan 19, 2023
Signed-off-by: amogkam <[email protected]>
amogkam
added
the
tests-ok
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
…y-project#31725) In previous PRs, we added support for specifying various batch formats and batch sizes for Preprocessors. However, with the stream API, these configurations were not respected as pandas batch format was hard-coded. In this PR, we introduce a private _transform_pipeline API to Preprocessor which we use in training ingest and pipelined batch inference, rather than manually calling map_batches. Closes ray-project#31503 Signed-off-by: amogkam <[email protected]> Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PRs, we added support for specifying various batch formats and batch sizes for Preprocessors.
However, with the stream API, these configurations were not respected as pandas batch format was hard-coded. In this PR, we introduce a private
_transform_pipelineAPI toPreprocessorwhich we use in training ingest and pipelined batch inference, rather than manually callingmap_batches.Closes #31503
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.