[AIR] Remove Checkpoint._object_ref
#31777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
clarkzinzow,
jiaodong,
Yard1,
matthewdeng and
amogkam
as code owners
bveeramani
changed the title
Checkpoint._object_ref attributeCheckpoint._object_ref
amogkam
approved these changes
Jan 19, 2023
Signed-off-by: Balaji Veeramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Why are these changes needed?
#31763 removes
Checkpoint.from_object_ref, but doesn't remove the now-unusedCheckpoint._object_ref. This PR cleans up the dead code.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.