Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] fix pytorch pbt failure test. #31791

Merged
merged 8 commits into from
Jan 24, 2023
Merged

[release] fix pytorch pbt failure test. #31791

merged 8 commits into from
Jan 24, 2023

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Jan 19, 2023 •
edited
Loading

The regression is introduced by #30705.

Also added some documentation into TorchTrainer so users know there is quite some magic happening :)

Tested manually in workspace.
Follow-up PR to add more strict assertions to the test.

Signed-off-by: xwjiang2010 [email protected]

Why are these changes needed?

Related issue number

#31784

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
[release] fix pytorch pbt failure test.
f646204 
The model is already wrapped in DDP. Need to access through `.module.model`.

Signed-off-by: xwjiang2010 <[email protected]>
krfricke
krfricke reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, minor suggestions for the doc fixes

python/ray/train/torch/torch_trainer.py Outdated Show resolved Hide resolved
python/ray/train/torch/torch_trainer.py Outdated Show resolved Hide resolved
python/ray/train/torch/torch_trainer.py Outdated Show resolved Hide resolved
krfricke
krfricke approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke krfricke merged commit b1c261c into ray-project:master Jan 24, 2023
@xwjiang2010 xwjiang2010 mentioned this pull request Feb 9, 2023
Open
@xwjiang2010 xwjiang2010 deleted the fix_torch_pbt_failure_release_test branch July 26, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@justinvyu justinvyu

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xwjiang2010 @krfricke @justinvyu