[tune] Deprecate passing a custom trial executor #31792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
xwjiang2010
reviewed
Jan 20, 2023
| @@ -163,6 +163,7 @@ def signal_interrupt_tune_run(sig: int, frame): | |||
| @PublicAPI | |||
| def run( | |||
| run_or_experiment: Union[str, Callable, Type], | |||
| *, | |||
There was a problem hiding this comment.
maybe not a big deal, hopefully people already do kwargs style when invoking the API :)
There was a problem hiding this comment.
although this is not entirely backward compatible.
xwjiang2010
approved these changes
Jan 20, 2023
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
The RayTrialExecutor is tightly coupled to many tune internal concepts. Expected behavior cannot be guaranteed if this ios customized. Lastly, we're in the process of refactoring the execution management and will likely consolidate the ray trial executor and trial runner in the near future. To prepare these changes, passing a custom ray trial executor should be deprecated. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Andrea Pisoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke [email protected]
Why are these changes needed?
The RayTrialExecutor is tightly coupled to many tune internal concepts. Expected behavior cannot be guaranteed if this ios customized. Lastly, we're in the process of refactoring the execution management and will likely consolidate the ray trial executor and trial runner in the near future.
To prepare these changes, passing a custom ray trial executor should be deprecated.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.