Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] Change default NCCL_SOCKET_IFNAME to blacklist veth #31824

Merged
merged 8 commits into from
Jan 24, 2023
Merged

[Train] Change default NCCL_SOCKET_IFNAME to blacklist veth #31824

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88d02c8
change
amogkam Jan 21, 2023
49b4093
add
amogkam Jan 21, 2023
5f0fdc5
Merge branch 'master' of github.com:ray-project/ray into default-nccl
amogkam Jan 21, 2023
ba276ee
remove
amogkam Jan 21, 2023
25210ff
comment
amogkam Jan 21, 2023
2c7f721
remove vethc
amogkam Jan 21, 2023
3b23dcb
no veth
amogkam Jan 23, 2023
79c7b31
Merge branch 'master' of github.com:ray-project/ray into default-nccl
amogkam Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions python/ray/train/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,8 @@
# as Trainable)
DISABLE_LAZY_CHECKPOINTING_ENV = "TRAIN_DISABLE_LAZY_CHECKPOINTING"

# Default NCCL_SOCKET_IFNAME.
# Use ethernet when possible.
# NCCL_SOCKET_IFNAME does a prefix match so "ens3" or "ens5" will match with
# "en".
DEFAULT_NCCL_SOCKET_IFNAME = "en,eth,bond"
# Blacklist virtualized networking.
DEFAULT_NCCL_SOCKET_IFNAME = "^lo,docker,vethc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually the reason is that it should be veth not vethc. c happened to be the first hex character of the ID I sent you.

that also explains why it was present in only 12 or the 16 -- the other 4 must have had c as the first character of the id.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch...then now I'm wondering why this passed. Maybe this is not needed at all 🤔. Let me run the test with this default removed.


# Key for AIR Checkpoint metadata in TrainingResult metadata
CHECKPOINT_METADATA_KEY = "checkpoint_metadata"