Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Clarify which RunConfig is used when there are multiple places to specify it #31959

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

justinvyu
Copy link
Contributor

@justinvyu justinvyu commented Jan 26, 2023

Why are these changes needed?

This PR clarifies where RunConfig can be specified. Also, when multiple configs are specified in different locations (in the Tuner and Trainer), this PR also logs information about which RunConfig is actually used.

Context

  • Scenario 1: RunConfig gets passed into both the Tuner and Trainer. The Tuner run config gets used, but this is not obvious/logged to the user.
  • Scenario 2: User tries to pass RunConfig in through the param_space. This silently fails (aka it doesn't get used), and it shouldn't be allowed, since the RunConfig cannot be tuned.
  • Scenario 3: Allowing a RunConfig in the Trainer when wrapping it with a Tuner makes it confusing whether or not this can be updated on restore, since it can be passed in again through the overwritten Trainable.

This PR logs something to the user for scenario 1, and disallows scenario 2.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke krfricke merged commit eab29ca into ray-project:master Jan 27, 2023
@justinvyu justinvyu deleted the tune/run_config_warnings branch January 27, 2023 19:21
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…es to specify it (ray-project#31959)

This PR clarifies where RunConfig can be specified. Also, when multiple configs are specified in different locations (in the Tuner and Trainer), this PR also logs information about which RunConfig is actually used.

Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants