[Tune] Clarify which RunConfig
is used when there are multiple places to specify it
#31959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR clarifies where
RunConfig
can be specified. Also, when multiple configs are specified in different locations (in the Tuner and Trainer), this PR also logs information about whichRunConfig
is actually used.Context
RunConfig
gets passed into both the Tuner and Trainer. The Tuner run config gets used, but this is not obvious/logged to the user.RunConfig
in through theparam_space
. This silently fails (aka it doesn't get used), and it shouldn't be allowed, since theRunConfig
cannot be tuned.This PR logs something to the user for scenario 1, and disallows scenario 2.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.