Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] Remove the non-useful comment in map_batches() #32020

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

c21
Copy link
Contributor

@c21 c21 commented Jan 28, 2023

Signed-off-by: Cheng Su [email protected]

Why are these changes needed?

This PR is a quick fix to remove the non-useful comment introduced in #31526, probably during debugging.

Replace the comment with a meaningful one.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl ericl merged commit 34e2cd5 into ray-project:master Jan 31, 2023
@c21 c21 deleted the fix-comment branch January 31, 2023 08:32
clarng pushed a commit to clarng/ray that referenced this pull request Jan 31, 2023
…ect#32020)

This PR is a quick fix to remove the non-useful comment introduced in ray-project#31526, probably during debugging.

Replace the comment with a meaningful one.
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…ect#32020)

This PR is a quick fix to remove the non-useful comment introduced in ray-project#31526, probably during debugging.

Replace the comment with a meaningful one.

Signed-off-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants