[observability][autoscaler] Ensure pending nodes is reset to 0 after scaling #32085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2023 14:53
|
cc @gvspraveen |
rkooo567
approved these changes
Jan 31, 2023
rkooo567
approved these changes
Jan 31, 2023
| { | ||
| "autoscaler_cluster_resources": 0, | ||
| "autoscaler_pending_resources": 0, | ||
| "autoscaler_pending_nodes": 0, |
There was a problem hiding this comment.
Any way to write a test that could've caught this?
There was a problem hiding this comment.
isn't this precisely a test that catches this?
rkooo567
added
the
@author-action-required
DmitriGekhtman
approved these changes
Jan 31, 2023
|
Remaining test failures look unrelated/flakey. merging |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…scaling (ray-project#32085) The previous way pending_nodes was calculated was prone to race conditions, instead, let's just always publish it in the main thread with other metrics. Closes ray-project#31982 --------- Co-authored-by: Alex <[email protected]> Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The previous way pending_nodes was calculated was prone to race conditions, instead, let's just always publish it in the main thread with other metrics.
Related issue number
Closes #31982
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.