clean up raylet client mocks #32216
Merged
clean up raylet client mocks #32216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clarence Ng <[email protected]>
rkooo567
approved these changes
Feb 7, 2023
|
cc @iycheng (have we auto-generated this before?) |
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Clarence Ng <[email protected]> Remove redundant mock classes. We just need one mock class for the interface that covers all the sub interface. The mock for the sub interface is unused Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clarence Ng [email protected]
Why are these changes needed?
Remove redundant mock classes. We just need one mock class for the interface that covers all the sub interface. The mock for the sub interface is unused
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.