Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Refactor Python API documentation for job submission #32252

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

c21
Copy link
Contributor

@c21 c21 commented Feb 7, 2023

Signed-off-by: Cheng Su [email protected]

Why are these changes needed?

This PR is to refactor Python API documentation for job submission, as same as #31204 .

See https://ray--32252.org.readthedocs.build/en/32252/cluster/running-applications/job-submission/jobs-package-ref.html .

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni
Copy link
Contributor

Looks reasonable, looks like the main change is that the main page is less cluttered and you have to click through to read the full dosctrings. Makes sense to make the API docs consistent

Screenshot 2023-02-06 at 5 05 37 PM

@architkulkarni architkulkarni added the release-blocker P0 Issue that blocks the release label Feb 7, 2023
@c21
Copy link
Contributor Author

c21 commented Feb 7, 2023

@architkulkarni - yes right, that's the main motivation.

@c21 c21 added the v2.3.0-pick label Feb 7, 2023
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this docs-only change for cherry picking into 2.3

@richardliaw richardliaw merged commit 7432367 into ray-project:master Feb 7, 2023
@c21 c21 deleted the cluster-api branch February 7, 2023 19:08
c21 added a commit to c21/ray that referenced this pull request Feb 7, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants