Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve][Doc] Refactor the Ray Serve API doc #32341

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[Serve][Doc] Refactor the Ray Serve API doc #32341

merged 1 commit into from
Feb 9, 2023

Conversation

sihanwang41
Copy link
Contributor

@sihanwang41 sihanwang41 commented Feb 8, 2023 •
edited
Loading

Signed-off-by: Sihan Wang [email protected]

Why are these changes needed?

cherry pick from #32307

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

cadedaniel
cadedaniel approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @zhe-thoughts @richardliaw for approval

zhe-thoughts
zhe-thoughts approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for cherry picking into 2.3.0

@cadedaniel cadedaniel merged commit 4d9450a into ray-project:releases/2.3.0 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

@jiaodong jiaodong Awaiting requested review from jiaodong jiaodong is a code owner

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale shrekris-anyscale is a code owner

@architkulkarni architkulkarni Awaiting requested review from architkulkarni architkulkarni is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sihanwang41 @cadedaniel @zhe-thoughts