Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][oom] Use retriable lifo policy for dask 3x nightly test #32361

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

clarng
Copy link
Contributor

@clarng clarng commented Feb 9, 2023

Signed-off-by: Clarence Ng [email protected]

Why are these changes needed?

3x nightly dask test is failing, due to enabling of group-by-owner oom killer policy

This switches the test to use the previous policy

Related issue number

#32195

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clarng clarng changed the title dask [core][oom] Use retriable lifo policy for dask x3 nightly test Feb 9, 2023
@clarng
Copy link
Contributor Author

clarng commented Feb 9, 2023

@clarng clarng marked this pull request as ready for review February 9, 2023 17:11
@clarng clarng changed the title [core][oom] Use retriable lifo policy for dask x3 nightly test [core][oom] Use retriable lifo policy for dask 3x nightly test Feb 9, 2023
@cadedaniel
Copy link
Member

Let's merge!

@rkooo567 rkooo567 merged commit 73b52e0 into ray-project:master Feb 10, 2023
@rkooo567
Copy link
Contributor

Personally don't prefer to have specialized config to nightly tests. Let's at least add this flag to the documentation and explain when it can be useful?

@zhe-thoughts zhe-thoughts linked an issue Feb 10, 2023 that may be closed by this pull request
@clarng
Copy link
Contributor Author

clarng commented Feb 10, 2023

Personally don't prefer to have specialized config to nightly tests. Let's at least add this flag to the documentation and explain when it can be useful?

#32419

@zhe-thoughts
Copy link
Collaborator

@clarng @cadedaniel Let's do a 2.3 cherry pick PR for this?

@clarng clarng mentioned this pull request Feb 10, 2023
6 tasks
clarng added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Clarence Ng <[email protected]>

3x nightly dask test is failing, due to enabling of group-by-owner oom killer policy

This switches the test to use the previous policy

Signed-off-by: Clarence Ng <[email protected]>
@clarng clarng deleted the dask branch February 10, 2023 18:21
cadedaniel pushed a commit that referenced this pull request Feb 10, 2023
… (#32425)

3x nightly dask test is failing, due to enabling of group-by-owner oom killer policy

This switches the test to use the previous policy

Signed-off-by: Clarence Ng <[email protected]>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…project#32361)

Signed-off-by: Clarence Ng <[email protected]>

3x nightly dask test is failing, due to enabling of group-by-owner oom killer policy

This switches the test to use the previous policy

Signed-off-by: Edward Oakes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ray 2.3 release] dask_on_ray_1tb_sort (a954ab7) OOM failure
5 participants