[data] Fix pandas import failures by moving it to a top-level data import #32447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
requested review from
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
ericl
added
the
tests-ok
jianoaix
approved these changes
Feb 13, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…port (ray-project#32447) Signed-off-by: Edward Oakes <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
… data import (ray-project#32447)" (ray-project#32533) This reverts commit bc01288. Signed-off-by: Edward Oakes <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
… data import (ray-project#32447)" (ray-project#32533) This reverts commit bc01288. Signed-off-by: elliottower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fixes #32435
I still do not know the exact root cause. I tried bisecting as far back as streaming worked, and it still happened before (though less frequently). It's possible this was a long outstanding issue.
I am not able to reproduce without streaming.
This PR sidesteps the issue by making pandas a normal import, which does not trigger the issue.
Related issue number
Closes #32435