[data] Streaming executor fixes #2 #32759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jianoaix <[email protected]>
jianoaix
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
c21
as code owners
ericl
reviewed
Feb 23, 2023
| if ray.data.context.DatasetContext.get_current().use_streaming_executor: | ||
| # In streaming execution of ds.iter_batches(), there is no partial | ||
| # execution so _num_computed() in LazyBlocklist is 0. | ||
| assert ds._plan.execute()._num_computed() == 0 |
There was a problem hiding this comment.
This is basically disabling this test. How about we just force it to use bulk executor instead?
There was a problem hiding this comment.
This assertion still has value as it checks that streaming execution didn't run LazyBlocklist.
ericl
reviewed
Feb 23, 2023
ericl
added
the
@author-action-required
ericl
approved these changes
Feb 23, 2023
jianoaix
removed
the
@author-action-required
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: elliottower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
.dataset_format()is hardcoded todefaultin streaming, the numpy is treated as a block type which is not supportedds.take()in bulk execution (v.s. in streaming this is not handled by LazyBlocklist)#32132
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.