[Serve] Add http request latency #32839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihanwang41
force-pushed
the
http_proxy_latency
branch
from
fd015c9
to
ff3fdc5
Compare
sihanwang41
requested review from
edoakes,
simon-mo,
jiaodong,
shrekris-anyscale,
architkulkarni and
a team
as code owners
edoakes
reviewed
Feb 28, 2023
| @@ -56,9 +56,9 @@ def verify_metrics(do_assert=False): | |||
| "serve_deployment_request_counter", | |||
| "serve_deployment_replica_starts", | |||
| # histogram | |||
| "deployment_processing_latency_ms_bucket", | |||
| "deployment_processing_latency_ms_count", | |||
| "deployment_processing_latency_ms_sum", | |||
There was a problem hiding this comment.
Do you know why this test was passing before if these metrics didn't exist yet?
There was a problem hiding this comment.
Sorry I misunderstood, this is a different metric. Still want to know if it was passing or not running though
There was a problem hiding this comment.
It is same metric, the reason it can pass before because we check whether the deployment_processing_latency_ms_sum string is inside the metrics blob.
For this change, I just want to make the test check more restrict.
architkulkarni
approved these changes
Feb 28, 2023
sihanwang41
force-pushed
the
http_proxy_latency
branch
from
e4bff52
to
265bba0
Compare
edoakes
approved these changes
Feb 28, 2023
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
force-pushed
the
http_proxy_latency
branch
from
265bba0
to
5d89517
Compare
shrekris-anyscale
approved these changes
Mar 1, 2023
| @@ -279,6 +279,9 @@ The following metrics are exposed by Ray Serve: | |||
| * error_code | |||
| * method | |||
| - The number of non-200 HTTP responses returned by each deployment. | |||
| * - ``serve_http_request_latency_ms`` [*] | |||
| - * endpoint | |||
| - The end-to-end latency of HTTP requests (measured from the Serve HTTP proxy). | |||
There was a problem hiding this comment.
Suggested change
| - The end-to-end latency of HTTP requests (measured from the Serve HTTP proxy). | |
| - A histogram of end-to-end latencies for HTTP requests (measured from the Serve HTTP proxy). |
There was a problem hiding this comment.
I will stick to the original one since it is following our current words convention.
|
@edoakes ping for merge! |
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
Add http request latency metrics. Signed-off-by: Jack He <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Add http request latency metrics. Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
Add http request latency metrics.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Add http request latency metrics. Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Add http request latency metrics. Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add http request latency metrics.
Related issue number
Closes #32711
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.