[serve] Prevent mixing single/multi-app config deployment #33340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
| # fields to support single-app mode, but in multi-app mode the host and port | ||
| # fields at the top-level deploy config is used instead. Eventually, after | ||
| # migration, we should remove these fields from ServeApplicationSchema. | ||
| host, port = config.host, config.port |
There was a problem hiding this comment.
Could we raise an error here if the user specifies an app-level host or port? This log is nice, but it doesn't get propagated back to the client.
There was a problem hiding this comment.
Hmm, if we want to prevent users from deploying it at all, perhaps we should just add a validator to check this in ServeDeploySchema.
There was a problem hiding this comment.
Yeah, that would be more general. If it doesn't impede any other behavior, then I'd prefer that.
There was a problem hiding this comment.
Agreed! I've added it here
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: Cindy Zhang <[email protected]>
zcin
changed the title
|
@sihanwang41 @edoakes PTAL! This PR blocks users from switching between config formats like we discussed. |
Signed-off-by: Cindy Zhang <[email protected]>
zcin
commented
Mar 16, 2023
| f"Port {app_config_dict['port']} is set in the config for " | ||
| f"application `{app_config.name}`. This will be ignored, as " | ||
| f"the port {port} from the top level deploy config is used." | ||
| ) |
There was a problem hiding this comment.
Removed the warnings here, as in a separate PR I will add validation in the schema itself.
zcin
changed the title
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
…t#33340) To simplify execution and not have to worry about covering all possible conflicts, we want to prevent users from deploying a single-app config (`ServeApplicationSchema`) first then switch to deploying a multi-app config (`ServeDeploySchema`), or vice versa. Eventually we want to deprecate deploying using `ServeApplicationSchema`, so this also encourages users to migrate. If users mix single-app and multi-app: - we will raise an error in `controller.deploy_apps` - the REST api will also return a `400 Response` with the error message Signed-off-by: Jack He <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…t#33340) To simplify execution and not have to worry about covering all possible conflicts, we want to prevent users from deploying a single-app config (`ServeApplicationSchema`) first then switch to deploying a multi-app config (`ServeDeploySchema`), or vice versa. Eventually we want to deprecate deploying using `ServeApplicationSchema`, so this also encourages users to migrate. If users mix single-app and multi-app: - we will raise an error in `controller.deploy_apps` - the REST api will also return a `400 Response` with the error message Signed-off-by: Edward Oakes <[email protected]>
chaowanggg
pushed a commit
to chaowanggg/ray-dev
that referenced
this pull request
Apr 4, 2023
…t#33340) To simplify execution and not have to worry about covering all possible conflicts, we want to prevent users from deploying a single-app config (`ServeApplicationSchema`) first then switch to deploying a multi-app config (`ServeDeploySchema`), or vice versa. Eventually we want to deprecate deploying using `ServeApplicationSchema`, so this also encourages users to migrate. If users mix single-app and multi-app: - we will raise an error in `controller.deploy_apps` - the REST api will also return a `400 Response` with the error message Signed-off-by: chaowang <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…t#33340) To simplify execution and not have to worry about covering all possible conflicts, we want to prevent users from deploying a single-app config (`ServeApplicationSchema`) first then switch to deploying a multi-app config (`ServeDeploySchema`), or vice versa. Eventually we want to deprecate deploying using `ServeApplicationSchema`, so this also encourages users to migrate. If users mix single-app and multi-app: - we will raise an error in `controller.deploy_apps` - the REST api will also return a `400 Response` with the error message Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…t#33340) To simplify execution and not have to worry about covering all possible conflicts, we want to prevent users from deploying a single-app config (`ServeApplicationSchema`) first then switch to deploying a multi-app config (`ServeDeploySchema`), or vice versa. Eventually we want to deprecate deploying using `ServeApplicationSchema`, so this also encourages users to migrate. If users mix single-app and multi-app: - we will raise an error in `controller.deploy_apps` - the REST api will also return a `400 Response` with the error message Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To simplify execution and not have to worry about covering all possible conflicts, we want to prevent users from deploying a single-app config (
ServeApplicationSchema) first then switch to deploying a multi-app config (ServeDeploySchema), or vice versa.Eventually we want to deprecate deploying using
ServeApplicationSchema, so this also encourages users to migrate.If users mix single-app and multi-app:
controller.deploy_apps400 Responsewith the error messageRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.