Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Only pin typeguard for Python <=3.7 #33402

Merged
merged 2 commits into from
Mar 17, 2023
Merged

[ci] Only pin typeguard for Python <=3.7 #33402

merged 2 commits into from
Mar 17, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Mar 17, 2023 •
edited
Loading

Why are these changes needed?

70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

comment
1674119 
Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke merged commit cf4c802 into ray-project:master Mar 17, 2023
@krfricke krfricke deleted the ci/typeguard branch March 17, 2023 01:54
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@krfricke @ProjectsByJackHe
[ci] Only pin typeguard for Python <=3.7 (ray-project#33402)
511380d 
70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Jack He <[email protected]>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@krfricke @edoakes
[ci] Only pin typeguard for Python <=3.7 (ray-project#33402)
6031240 
70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@krfricke @peytondmurray
[ci] Only pin typeguard for Python <=3.7 (ray-project#33402)
a986b0b 
70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Signed-off-by: Kai Fricke <[email protected]>
chaowanggg pushed a commit to chaowanggg/ray-dev that referenced this pull request Apr 4, 2023
@krfricke @chaowanggg
[ci] Only pin typeguard for Python <=3.7 (ray-project#33402)
466d55e 
70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: chaowang <[email protected]>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@krfricke @elliottower
[ci] Only pin typeguard for Python <=3.7 (ray-project#33402)
a90a0d9 
70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@krfricke @ProjectsByJackHe
[ci] Only pin typeguard for Python <=3.7 (ray-project#33402)
7b92608 
70dbf41 pinned typeguard to make ax-platform work again on latest master, but a8a1ed0 updated ax-platform for python >= 3.8. The typeguard pin is incompatible with this pinned version. So we need to pin typeguard only for Python 3.7 to make the image builds for 3.8+ work again.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees

@matthewdeng matthewdeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krfricke @matthewdeng