Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Revamp ray core design patterns doc [19/n]: async actor #33595

Merged
merged 7 commits into from
Mar 28, 2023
Merged

[Doc] Revamp ray core design patterns doc [19/n]: async actor #33595

merged 7 commits into from
Mar 28, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Mar 22, 2023 •
edited
Loading

Why are these changes needed?

  • Move the code to doc_code for CI
  • Edit pass

Related issue number

#27048

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao marked this pull request as ready for review March 22, 2023 19:27
@jjyao jjyao requested a review from a team as a code owner March 22, 2023 19:27
@ericl
Copy link
Contributor

ericl commented Mar 23, 2023

Good to merge once doc build passes.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 23, 2023
@jjyao jjyao merged commit 3ad40a4 into ray-project:master Mar 28, 2023
@jjyao jjyao deleted the async branch March 28, 2023 05:44
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@jjyao @elliottower
[Doc] Revamp ray core design patterns doc [19/n]: async actor (ray-pr…
0d74ad3 
…oject#33595)

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@jjyao @ProjectsByJackHe
[Doc] Revamp ray core design patterns doc [19/n]: async actor (ray-pr…
fb1a310 
…oject#33595)

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @ericl