[Data] [hotfix] Fix test_stats
#33788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
amogkam
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
jianoaix
approved these changes
Mar 28, 2023
c21
approved these changes
Mar 28, 2023
Signed-off-by: amogkam <[email protected]>
8 tasks
|
Bulk tests seem to be failing. |
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
zhe-thoughts
approved these changes
Mar 28, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
ray-project#33713 changed test_dataset_stats_basic to check for iterations stats when using the streaming executor. ray-project#33620 changed the stats behavior for streaming executor and hadn't pulled in ray-project#33713 so test_stats was passing. When both are merged in master, test_stats started failing. This PR fixes it. --------- Signed-off-by: amogkam <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
ray-project#33713 changed test_dataset_stats_basic to check for iterations stats when using the streaming executor. ray-project#33620 changed the stats behavior for streaming executor and hadn't pulled in ray-project#33713 so test_stats was passing. When both are merged in master, test_stats started failing. This PR fixes it. --------- Signed-off-by: amogkam <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33713 changed
test_dataset_stats_basicto check for iterations stats when using the streaming executor.#33620 changed the stats behavior for streaming executor and hadn't pulled in #33713 so
test_statswas passing.When both are merged in master,
test_statsstarted failing. This PR fixes it.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.