[CI][Clean][03] Break run_release_test into smaller functions #33951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-ci-clean-02
branch
2 times, most recently
from
0b2db8d
to
bfa4ae9
Compare
can-anyscale
force-pushed
the
can-ci-clean-03
branch
from
7ad5f65
to
4461f13
Compare
can-anyscale
force-pushed
the
can-ci-clean-03
branch
from
4461f13
to
18ae767
Compare
Clean up client runner
Signed-off-by: Cuong Nguyen <[email protected]>
Clean up client runner
…em yet. Signed-off-by: Cuong Nguyen <[email protected]>
Clean up client runner
Signed-off-by: Cuong Nguyen <[email protected]>
Clean up client runner
* Migrate dataset_shuffle_random_shuffle_1tb to run on anyscale job v2 Signed-off-by: Cuong Nguyen <[email protected]> * Migrate some tests off of deprecated infrastructure: - dataset_shuffle_random_shuffle_1tb to run on anyscale job v2 - tune_scalability_result_throughput_single_node to run on anyscale job v2 Signed-off-by: Cuong Nguyen <[email protected]> * Deprecate test client and job runner. Signed-off-by: Cuong Nguyen <[email protected]> * Clean up AnyscaleJobRunner Signed-off-by: Cuong Nguyen <[email protected]> * Linters Signed-off-by: Cuong Nguyen <[email protected]> * Lint Signed-off-by: Cuong Nguyen <[email protected]> * Fix import Signed-off-by: Cuong Nguyen <[email protected]> * Correct indentation Signed-off-by: Cuong Nguyen <[email protected]> --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Cuong Nguyen <[email protected]>
can-anyscale
force-pushed
the
can-ci-clean-03
branch
from
18ae767
to
58ae175
Compare
aslonnie
approved these changes
Apr 11, 2023
|
Testing the new-borns are always good ideas ;). I'll investigate their logic more and add more tests as a follow up |
scv119
approved these changes
Apr 12, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…oject#33951) A purely refactor diff. Break run_release_test in glue.py into smaller functions so they are easier to read, test and change. It helps me to make future change easier too. Signed-off-by: Cuong Nguyen <[email protected]> --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Cuong Nguyen <[email protected]> --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…oject#33951) A purely refactor diff. Break run_release_test in glue.py into smaller functions so they are easier to read, test and change. It helps me to make future change easier too. Signed-off-by: Cuong Nguyen <[email protected]> --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Cuong Nguyen <[email protected]> --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A purely refactor diff. Break run_release_test in glue.py into smaller functions so they are easier to read, test and change. It helps me to make future change easier too.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.