[CI] Add GCE variances to Data tests #34105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5984f1e.
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
This reverts commit de05655. Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
8 tasks
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
|
|
||
| head_node_type: | ||
| name: head_node | ||
| instance_type: n1-standard-64-nvidia-tesla-t4-1 |
There was a problem hiding this comment.
We actually don't have this type of machine, the list is here: https://github.com/anyscale/product/blob/master/backend/utils/allowed_gpus.yaml
|
If you can scan through the list of failing tests real quick and see if there are any obvious such as a wrong type of machines, that would be great. If the error is not comprehensible then you can merge the PR. |
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
can-anyscale
approved these changes
Apr 14, 2023
|
are the failing tests ok? |
|
@amogkam yeah. Discussed with @can-anyscale and we're going to merge the PR with the failing tests. |
|
Hi yes, please merge even if they fail if the failures are not comprehensible or infra failure related. They are running on GCE stack for the first time so we expect some of them to fail. Merge into master will help the infra team to look at them easier. Thankks |
|
ok can you add a pr description please? |
This was referenced Apr 18, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
This PR configures BuildKite to run Data release tests on GCE. I excluded the parquet_metadata_resolution and shuffle_data_loader release tests because more work is required to migrate those tests. --------- Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: elliottower <[email protected]>
8 tasks
amogkam
pushed a commit
that referenced
this pull request
Apr 24, 2023
This PR configures BuildKite to run the shuffle_data_loader Data release tests on GCE. This test was previously excluded in #34105. --------- Signed-off-by: Balaji Veeramani <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
This PR configures BuildKite to run Data release tests on GCE. I excluded the parquet_metadata_resolution and shuffle_data_loader release tests because more work is required to migrate those tests. --------- Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Jack He <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
This PR configures BuildKite to run the shuffle_data_loader Data release tests on GCE. This test was previously excluded in ray-project#34105. --------- Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
This PR configures BuildKite to run the shuffle_data_loader Data release tests on GCE. This test was previously excluded in ray-project#34105. --------- Signed-off-by: Balaji Veeramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR configures BuildKite to run Data release tests on GCE. I excluded the
parquet_metadata_resolutionandshuffle_data_loaderrelease tests because more work is required to migrate those tests.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.