Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] Fix test failure caused by lack of ordring in default streaming executor #34120

Merged
merged 10 commits into from
Apr 6, 2023

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 6, 2023

Why are these changes needed?

The failure observed here: https://buildkite.com/ray-project/oss-ci-build-pr/builds/17595#annotation-018753eb-10bf-4eed-b785-cbf80e607a18

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jianoaix
Copy link
Contributor Author

jianoaix commented Apr 6, 2023

Test is passing now.

@jianoaix jianoaix merged commit bf076f9 into ray-project:master Apr 6, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…g executor (ray-project#34120)

* Revert "[Datasets] Revert "Enable streaming executor by default (ray-project#32493)" (ray-project#33485)"

This reverts commit 5c79954.

* Fix test failure caused by lack of ordring in default streaming executor

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…g executor (ray-project#34120)

* Revert "[Datasets] Revert "Enable streaming executor by default (ray-project#32493)" (ray-project#33485)"

This reverts commit 5c79954.

* Fix test failure caused by lack of ordring in default streaming executor

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants