Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix std::move without std namespace #34149

Merged
merged 2 commits into from
Apr 10, 2023
Merged

[core] Fix std::move without std namespace #34149

merged 2 commits into from
Apr 10, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Apr 7, 2023

Why are these changes needed?

This is preventing build from newer mac.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
all
6464101 
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx requested a review from a team as a code owner April 7, 2023 01:09
@rickyyx
commit
8522c8f 
Signed-off-by: rickyyx <[email protected]>
cadedaniel
cadedaniel approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I wonder if we should run the Mac build steps on every PR to prevent these kinds of issues from breaking master.

@rickyyx
Copy link
Contributor Author

rickyyx commented Apr 7, 2023

It's only breaking m1 mac with newer version of clang I believe. So running the mac build might not help.

@scv119 scv119 merged commit 76946cf into ray-project:master Apr 10, 2023
@rickyyx rickyyx assigned rickyyx and unassigned scv119 Apr 10, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@rickyyx @elliottower
[core] Fix std::move without std namespace (ray-project#34149)
2b79733 
This is preventing build from newer mac.
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@rickyyx @ProjectsByJackHe
[core] Fix std::move without std namespace (ray-project#34149)
738f7e9 
This is preventing build from newer mac.
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

Assignees

@rickyyx rickyyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickyyx @cadedaniel @rkooo567 @scv119