[build] Fix build on latest clang #34151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
reviewed
Apr 7, 2023
.bazelrc
Outdated
| @@ -10,6 +10,7 @@ build --compilation_mode=opt | |||
| # Using C++ 17 on all platforms. | |||
| build:linux --cxxopt="-std=c++17" | |||
| build:macos --cxxopt="-std=c++17" | |||
| build:macos --copt="-Wno-error=implicit-function-declaration" | |||
There was a problem hiding this comment.
Could we do something like
build --per_file_copt="external/.*@-Wno-unused-result"
build:linux --per_file_copt="-\\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGPR_MANYLINUX1"
for only external dependencies? We could probably do that for the vendored thirdparty libs as well?
rickyyx
approved these changes
Apr 7, 2023
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
The latest clang just make some warning as error by default. This PR tries to fix that. More detail in https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213/1
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
The latest clang just make some warning as error by default. This PR tries to fix that. More detail in https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213/1 Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
The latest clang just make some warning as error by default. This PR tries to fix that. More detail in https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213/1 Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The latest clang just make some warning as error by default. This PR tries to fix that.
More detail in https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213/1
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.