Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Update coding style for RuntimeEnvTest.java #34160

Merged
merged 1 commit into from
Apr 10, 2023
Merged

[Java] Update coding style for RuntimeEnvTest.java #34160

merged 1 commit into from
Apr 10, 2023

Conversation

XiaodongLv
Copy link
Contributor

@XiaodongLv XiaodongLv commented Apr 7, 2023 •
edited
Loading

Why are these changes needed?

Update coding style for RuntimeEnvTest.java

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

update coding style
000ad5b 
Signed-off-by: XiaodongLv <[email protected]>
jovany-wang
jovany-wang approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@jovany-wang jovany-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovany-wang jovany-wang merged commit bd525f3 into ray-project:master Apr 10, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@XiaodongLv @elliottower
[Java] Update coding style for RuntimeEnvTest.java (ray-project#34160)
aa8c5d9 
Update coding style for RuntimeEnvTest.java

Co-authored-by: XiaodongLv <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@XiaodongLv @ProjectsByJackHe
[Java] Update coding style for RuntimeEnvTest.java (ray-project#34160)
5146a59 
Update coding style for RuntimeEnvTest.java

Co-authored-by: XiaodongLv <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovany-wang jovany-wang jovany-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XiaodongLv @jovany-wang