[CI][Green-Ray][4] Compute and store unique crash pattern from logs #34200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-ci-errors-04
branch
6 times, most recently
from
adf46b3
to
532ddfd
Compare
can-anyscale
changed the title
can-anyscale
force-pushed
the
can-ci-errors-04
branch
from
532ddfd
to
59765e3
Compare
aslonnie
reviewed
Apr 10, 2023
|
This logic mainly attempts to capture logs from ray logs (https://docs.ray.io/en/latest/ray-observability/ray-logging.html#logging-directory-structure). 100% agree there are observability improvement/loves to do more in these logs. |
aslonnie
reviewed
Apr 10, 2023
can-anyscale
force-pushed
the
can-ci-errors-03
branch
from
b8f6669
to
57fa827
Compare
can-anyscale
force-pushed
the
can-ci-errors-04
branch
2 times, most recently
from
d4b66ef
to
c6acbb5
Compare
can-anyscale
requested review from
ericl,
richardliaw,
rkooo567,
jjyao,
gjoliver,
krfricke,
xwjiang2010,
amogkam and
matthewdeng
as code owners
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
…atterns Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
can-anyscale
force-pushed
the
can-ci-errors-04
branch
from
d3fce8d
to
485a199
Compare
krfricke
requested changes
Apr 21, 2023
release/ray_release/reporter/db.py
Outdated
Comment on lines
20
to
22
| def compute_crash_pattern(self, logs: str) -> str: | ||
| stack_trace = self._compute_stack_trace(logs.splitlines()) | ||
| return self._compute_signature(stack_trace)[:4000] # limit of databrick field |
There was a problem hiding this comment.
This doesn't really have anything to do with the Databricks reporter. Can we move the crash pattern parsing into a separate python file?
krfricke
added
the
@author-action-required
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
can-anyscale
removed
the
@author-action-required
Signed-off-by: Cuong Nguyen <[email protected]>
krfricke
approved these changes
Apr 21, 2023
Comment on lines
+7
to
+9
| class LogAggregator: | ||
| def __init__(self, log: str): | ||
| self.log = log |
There was a problem hiding this comment.
Just a nit, but it doesn't look like we actually need a class here (we could just have functions instead) - but fine with me
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ay-project#34200) This PR computes and aggregate unique crash patterns from logs, then store them in Databricks. Later on, this will help us build a dashboard for heat map of errors from aggregated logs, help us prioritize the most impactful errors to fix. Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ay-project#34200) This PR computes and aggregate unique crash patterns from logs, then store them in Databricks. Later on, this will help us build a dashboard for heat map of errors from aggregated logs, help us prioritize the most impactful errors to fix. Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
…ay-project#34200) This PR computes and aggregate unique crash patterns from logs, then store them in Databricks. Later on, this will help us build a dashboard for heat map of errors from aggregated logs, help us prioritize the most impactful errors to fix. Signed-off-by: Cuong Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR computes and aggregate unique crash patterns from logs, then store them in Databricks. Later on, this will help us build a dashboard for heat map of errors from aggregated logs, help us prioritize the most impactful errors to fix.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.