[RLlib] Fixed a bug with kl divergence calculation of torch.Dirichlet distribution within RLlib #34209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
context:
https://discuss.ray.io/t/passing-custom-action-dist/10111
The fix, basically lets the class inherit the default behavior of the parent for computing the kl_divergence which is the correct way of doing it.
self.dist.kl_divergence is not a valid api, instead we should use torch.distributions.kl.kl_divergence(self.dist, other.dist)
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.