Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] No early kickoff by default for workflow test #34213

Merged
merged 1 commit into from
Apr 10, 2023
Merged

[ci] No early kickoff by default for workflow test #34213

merged 1 commit into from
Apr 10, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Apr 10, 2023 •
edited
Loading

Why are these changes needed?

We have seen workflow test fails on PRs with totally unrelated content because of the re-using of the cached docker image.

Seems the workflow test does have a dependency on the wheels built.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
init
08781de 
Signed-off-by: rickyyx <[email protected]>
jjyao
jjyao approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some PR descriptions.

krfricke
krfricke approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from CI perspective

@fishbone fishbone merged commit 34aba19 into ray-project:master Apr 10, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@rickyyx @elliottower
[ci] No early kickoff by default for workflow test (ray-project#34213)
d49858e 
Signed-off-by: rickyyx <[email protected]>

We have seen workflow test fails on PRs with totally unrelated content because of the re-using of the cached docker image.
- ray-project#34101

Seems the workflow test does have a dependency on the wheels built.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@rickyyx @ProjectsByJackHe
[ci] No early kickoff by default for workflow test (ray-project#34213)
743cce7 
Signed-off-by: rickyyx <[email protected]>

We have seen workflow test fails on PRs with totally unrelated content because of the re-using of the cached docker image.
- ray-project#34101

Seems the workflow test does have a dependency on the wheels built.

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@jjyao jjyao jjyao approved these changes

Assignees

@krfricke krfricke

@fishbone fishbone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickyyx @jjyao @krfricke @fishbone