[Data] Support using concurrent actors for ActorPool
#34253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amogkam <[email protected]>
amogkam
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
ericl
reviewed
Apr 11, 2023
There was a problem hiding this comment.
A couple questions:
- Should we always use this thread-pool code path regardless of the setting?
- Do we have any segfault issues right now?
- How does this relate to the thread-based pipelining code you have for accelerated prefetch? It seems like we could also use that pipeline verbatim, with each actor thread feeding into the pipeline and awaiting the output at the end.
|
Signed-off-by: amogkam <[email protected]>
…ool-concurrent-actor
Signed-off-by: amogkam <[email protected]>
|
Made the change for point 1 |
amogkam
commented
Apr 11, 2023
|
|
||
| class _Wrapper(callable_cls): | ||
| def __init__(self, *args, **kwargs): | ||
| self.thread_pool_executor = ThreadPoolExecutor(max_workers=1) |
There was a problem hiding this comment.
@ericl we have max_workers=1 here so the user's UDF will always be run in a single thread.
amogkam
commented
Apr 11, 2023
Comment on lines
+162
to
+163
| # Make sure user's UDF is not running concurrently. | ||
| assert len(set(thread_ids)) == 1 |
ericl
approved these changes
Apr 11, 2023
c21
approved these changes
Apr 11, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…4253) Support using concurrent actors for ActorPool. We do this by gating the user UDF in a separate threadpool of max size 1. --------- Signed-off-by: amogkam <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…4253) Support using concurrent actors for ActorPool. We do this by gating the user UDF in a separate threadpool of max size 1. --------- Signed-off-by: amogkam <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using concurrent actors for
ActorPool. We do this by gating the user UDF in a separate threadpool of max size 1.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.