Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Add default app name #34260

Merged
merged 19 commits into from
Apr 25, 2023
Merged

[Serve] Add default app name #34260

merged 19 commits into from
Apr 25, 2023

Conversation

sihanwang41
Copy link
Contributor

@sihanwang41 sihanwang41 commented Apr 11, 2023 •
edited
Loading

Why are these changes needed?

  • Add default name for applications deploy.
  • Fix a bug for not setting the deployment name correctly for function deployment.
  • Fix unit tests because of the default application name change.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sihanwang41 sihanwang41 self-assigned this Apr 11, 2023
@sihanwang41 sihanwang41 mentioned this pull request Apr 11, 2023
Closed
@sihanwang41 sihanwang41 force-pushed the default_app_name branch 2 times, most recently from 4ffd1e0 to 6a94454 Compare April 22, 2023 17:20
@ollie-iterators
Copy link

The documentation test should be fixed by merging in recent changes

@sihanwang41 sihanwang41 marked this pull request as ready for review April 24, 2023 04:12
edoakes
edoakes reviewed Apr 24, 2023
View reviewed changes
python/ray/serve/_private/deployment_graph_build.py Show resolved Hide resolved
python/ray/serve/_private/constants.py Outdated
@@ -29,7 +29,7 @@
DEFAULT_GRPC_PORT = 9000

#: Default Serve application name
SERVE_DEFAULT_APP_NAME = ""
SERVE_DEFAULT_APP_NAME = "DEFAULT_RAY_SERVE_APP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is potentially user facing so this name is a bit ugly, should we just make it "default" ?

@sihanwang41
[Serve] Add default app name
d952fae 
Signed-off-by: Sihan Wang <[email protected]>
@sihanwang41
Fix
2da4f3e 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
eea4beb 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
f7a5590 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
c86a227 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
920498b 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
442328e 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
0320cfc 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
87c928e 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
1e471e5 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
4cec9a3 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
ae01aff 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
20f0e59 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
0d54391 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
d87d61d 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
62ca7db 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
test
e4c67dc 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Fix
ccb7ea4 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Update
dead823 
Signed-off-by: sihanwang41 <[email protected]>
@sihanwang41
Copy link
Contributor Author

test failure is not related to serve.

@sihanwang41 sihanwang41 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Apr 25, 2023
@architkulkarni architkulkarni merged commit 9928085 into ray-project:master Apr 25, 2023
architkulkarni added a commit that referenced this pull request Apr 25, 2023
@architkulkarni
Revert "[Serve] Add default app name (#34260)"
62be709 
This reverts commit 9928085.
@architkulkarni architkulkarni mentioned this pull request Apr 25, 2023
Closed
@kevin85421 kevin85421 mentioned this pull request Apr 26, 2023
Closed
@kevin85421
Copy link
Member

Hi, this PR seems to cause the compatibility test in KubeRay failing consistently. See #34799 for more details. Thanks!

ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@sihanwang41 @ProjectsByJackHe
[Serve] Add default app name (ray-project#34260)
4e6a968 
Add default name for applications deploy.
Fix a bug for not setting the deployment name correctly for function deployment.
Fix unit tests because of the default application name change.

Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@sihanwang41 @architkulkarni
[Serve] Add default app name (ray-project#34260)
79e824c 
Add default name for applications deploy.
Fix a bug for not setting the deployment name correctly for function deployment.
Fix unit tests because of the default application name change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@sihanwang41 sihanwang41

@edoakes edoakes

@zcin zcin

@shrekris-anyscale shrekris-anyscale

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sihanwang41 @ollie-iterators @kevin85421 @edoakes @architkulkarni @zcin @shrekris-anyscale