Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no_early_kickoff][RLlib][Docs] Add Catalog user-guide to docs (#33898) #34267

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst commented Apr 11, 2023

Why are these changes needed?

2.4 pick for adding the docs for Catalogs for RLModules to the docs.

#34161 should go in first.

@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib][Docs] Add Catalog user-guide to docs [RLlib][Docs] Add Catalog user-guide to docs (#33898) Apr 11, 2023
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (@clarng will decide when to pick depending on whether docs build is green). Thanks @ArturNiederfahrenhorst for the great work!

@ArturNiederfahrenhorst
Copy link
Contributor Author

ArturNiederfahrenhorst commented Apr 11, 2023

I'm re-running a couple of tests since for some nodes Ray didn't come up.

@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib][Docs] Add Catalog user-guide to docs (#33898) [no_early_kickoff][RLlib][Docs] Add Catalog user-guide to docs (#33898) Apr 13, 2023
@ArturNiederfahrenhorst ArturNiederfahrenhorst force-pushed the pick3c22ad6704a83adb1e4dcf47d9b10c10a48b99e2 branch from 06b1f17 to 03c2196 Compare April 17, 2023 21:45
@ArturNiederfahrenhorst
Copy link
Contributor Author

ArturNiederfahrenhorst commented Apr 17, 2023

@jjyao I've rebased onto latest release branch head. Lmk if anything comes up.

@jjyao jjyao merged commit 174abe6 into ray-project:releases/2.4.0 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants