[Metrics] Fix shared memory is not displayed properly #34301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <[email protected]>
Signed-off-by: SangBin Cho <[email protected]>
rickyyx
approved these changes
Apr 12, 2023
|
What is CP? And I just found out from the dashboard when I navigate it through lol (I occasionally navigate around the dashboard from release tests for dogfooding..) |
|
CP, cherry-pick |
|
ah hmm.. yeah I think we should. |
cadedaniel
added a commit
that referenced
this pull request
Apr 14, 2023
This reverts commit 688ddf6.
rkooo567
pushed a commit
that referenced
this pull request
Apr 15, 2023
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Apr 17, 2023
8 tasks
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
…oject#34301)" (ray-project#34407) This reverts commit 688ddf6.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
) Looks like we incorrectly recorded shared memory, and incorrectly displayed it to the metrics graph (I forgot to append ray_) Signed-off-by: elliottower <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…oject#34301)" (ray-project#34407) This reverts commit 688ddf6. Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
) Looks like we incorrectly recorded shared memory, and incorrectly displayed it to the metrics graph (I forgot to append ray_) Signed-off-by: Jack He <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…oject#34301)" (ray-project#34407) This reverts commit 688ddf6. Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Looks like we incorrectly recorded shared memory, and incorrectly displayed it to the metrics graph (I forgot to append
ray_)Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.