Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Bisect][1] Skeleton for automated bisect of release tests #34329

Merged
merged 11 commits into from
Apr 15, 2023

Conversation

can-anyscale
Copy link
Collaborator

Why are these changes needed?

A script to bisect release test failures. This PR only contains a skeleton and unit-tests

Related issue number

Issue #34243

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests

Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

release/ray_release/scripts/ray_bisect.py Outdated Show resolved Hide resolved
release/ray_release/scripts/ray_bisect.py Outdated Show resolved Hide resolved
Signed-off-by: Cuong Nguyen <[email protected]>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Linter seems to be failing

Signed-off-by: Cuong Nguyen <[email protected]>
@ollie-iterators
Copy link

The documentation test should be fixed by merging in recent changes.

@krfricke krfricke merged commit 26f391f into master Apr 15, 2023
@krfricke krfricke deleted the can-ci-bisect branch April 15, 2023 07:25
vitsai pushed a commit to vitsai/ray that referenced this pull request Apr 17, 2023
…roject#34329)

A script to bisect release test failures. This PR only contains a skeleton and unit-tests

Signed-off-by: Cuong Nguyen <[email protected]>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…roject#34329)

A script to bisect release test failures. This PR only contains a skeleton and unit-tests

Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…roject#34329)

A script to bisect release test failures. This PR only contains a skeleton and unit-tests

Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants