-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Bisect][2] Actually bisect test failures on buildkite #34331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krfricke
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
can-anyscale
force-pushed
the
can-ci-bisect-02
branch
2 times, most recently
from
April 14, 2023 15:19
6dd385e
to
eca2aa8
Compare
krfricke
approved these changes
Apr 15, 2023
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
can-anyscale
force-pushed
the
can-ci-bisect-02
branch
from
April 15, 2023 23:41
eca2aa8
to
fbd6e7f
Compare
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
…ct#34331) Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways: - It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step - It only runs one test at a time, which is less effective when the range gets small Signed-off-by: Cuong Nguyen <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ct#34331) Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways: - It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step - It only runs one test at a time, which is less effective when the range gets small Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ct#34331) Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways: - It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step - It only runs one test at a time, which is less effective when the range gets small Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways:
Related issue number
Issue #34243
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.