Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Bisect][2] Actually bisect test failures on buildkite #34331

Merged
merged 26 commits into from
Apr 17, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Apr 12, 2023

Why are these changes needed?

Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways:

  • It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step
  • It only runs one test at a time, which is less effective when the range gets small

Related issue number

Issue #34243

Checks

Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@can-anyscale can-anyscale force-pushed the can-ci-bisect-02 branch 2 times, most recently from 6dd385e to eca2aa8 Compare April 14, 2023 15:19
Base automatically changed from can-ci-bisect to master April 15, 2023 07:25
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
@krfricke krfricke merged commit 6978985 into master Apr 17, 2023
@krfricke krfricke deleted the can-ci-bisect-02 branch April 17, 2023 13:22
vitsai pushed a commit to vitsai/ray that referenced this pull request Apr 17, 2023
…ct#34331)

Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways:
- It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step
- It only runs one test at a time, which is less effective when the range gets small

Signed-off-by: Cuong Nguyen <[email protected]>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…ct#34331)

Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways:
- It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step
- It only runs one test at a time, which is less effective when the range gets small

Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…ct#34331)

Implement the actual functions to run test and bisect on buildkite. This first implementation is pretty naive in several ways:
- It uses a main bisect orchestration step that waits for test steps. We can make it more efficient here by sub-bisect orchestration step
- It only runs one test at a time, which is less effective when the range gets small

Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants