[core][state] Efficient get/list actors with filters on some high-cardinality fields #34348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <[email protected]>
rickyyx
requested review from
a team,
wuisawesome,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz,
raulchen,
fishbone and
scv119
as code owners
|
I am planning to do similar things for tasks + workers + objects, and plan to work on other issues before optimizing for other resources, which usually has a lower cardinality I believe (e.g. placement groups, runtime-envs)? cc @rkooo567 |
rickyyx
added
the
tests-ok
rkooo567
approved these changes
Apr 14, 2023
rkooo567
approved these changes
Apr 14, 2023
|
cc @scv119 for the protobuf approval |
8 tasks
Here: #34415 |
scv119
approved these changes
Apr 15, 2023
8 tasks
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
…dinality fields ray-project#34348 Signed-off-by: rickyyx <[email protected]> This improves the state API for listing/getting actors: if filtering by id/state/job, filtering is pushed down to the source (GCS). Other state API resources will be implemented in a similar way (e.g. tasks/workers).
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…dinality fields ray-project#34348 Signed-off-by: rickyyx <[email protected]> This improves the state API for listing/getting actors: if filtering by id/state/job, filtering is pushed down to the source (GCS). Other state API resources will be implemented in a similar way (e.g. tasks/workers). Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…dinality fields ray-project#34348 Signed-off-by: rickyyx <[email protected]> This improves the state API for listing/getting actors: if filtering by id/state/job, filtering is pushed down to the source (GCS). Other state API resources will be implemented in a similar way (e.g. tasks/workers). Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
…m state api (ray-project#34433) Similar to ray-project#34348 This pushes down the below filters to GCS (source-side) filtering. actor_id task id task name job id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This improves the state API for listing/getting actors: if filtering by id/state/job, filtering is pushed down to the source (GCS).
Other state API resources will be implemented in a similar way (e.g. tasks/workers).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.