-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc][AIR] Improve visibility of Trainer restore and stateful callback restoration #34350
[Doc][AIR] Improve visibility of Trainer restore and stateful callback restoration #34350
Conversation
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…restore_loose_ends
Signed-off-by: Justin Yu <[email protected]>
…restore_loose_ends Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…restore_loose_ends
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Once checkpointing is enabled, you can follow :ref:`this guide <train-fault-tolerance>` | ||
to enable fault tolerance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't want to link this since this is in the Deep Learning guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was trying to share some content between the two. I linked it to a section that doesn't really depend on DL trainers. I think it's okay for now, and we can rethink the docs/user guide structure as part of the docs side of the layering project. wdyt?
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…restore_loose_ends
…restore_loose_ends
…restore_loose_ends
…k restoration (ray-project#34350) Signed-off-by: elliottower <[email protected]>
…k restoration (ray-project#34350) Signed-off-by: Jack He <[email protected]>
Why are these changes needed?
This PR moves the FAQ section on Train experiment restoration to the DL/GBDT user guides. Plus this PR makes these code snippets tested. Secondly, this PR improves the docstrings of methods to implement for saving/restoring stateful Callbacks.
Links for reviewers
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.