[RLlib] Fix two RL docs examples #34353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
| my_head = catalog.build_my_head("torch") # doctest: +SKIP | ||
| out = my_head(...) # doctest: +SKIP | ||
| my_head = catalog.build_my_head("torch") | ||
| out = my_head(torch.Tensor([[1]])) |
There was a problem hiding this comment.
When I wrote them, I assumed that these # doctest: +SKIP would work on them. It does not.
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
avnishn
reviewed
Apr 13, 2023
| ) | ||
| policy_dict, is_policy_to_train = config.get_multi_agent_setup( | ||
| env=gym.make("CartPole-v1")) | ||
| is_policy_to_train("pol1") |
There was a problem hiding this comment.
do you want to delete the output of these commands? otherwise lgtm
|
Thanks for making the docs build green again ❤️ #fasterandgreener |
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
added a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
jjyao
pushed a commit
that referenced
this pull request
Apr 19, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We currently have two RLlib doc tests failing.
This PR fixes both.