Serve Dashboard features polish #34391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make it more clear when a log file is empty Signed-off-by: Alan Guo <[email protected]>
edoakes
approved these changes
Apr 14, 2023
Signed-off-by: Alan Guo <[email protected]>
|
Nit: why is "this" highlighted in red? |
|
Let's follow up with ^ in a separate PR |
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Apr 17, 2023
Filter out serve system endpoints from grafana dashboards Make it more clear when a log file is empty
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Filter out serve system endpoints from grafana dashboards Make it more clear when a log file is empty Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Filter out serve system endpoints from grafana dashboards Make it more clear when a log file is empty Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
- Update page titles to show more info about the page.Related issue number
fixes #34077
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.