Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Deflake gcs_client_test.cc #34411

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[core] Deflake gcs_client_test.cc #34411

merged 1 commit into from
Apr 17, 2023

Conversation

cadedaniel
Copy link
Member

  • Hypothesis is that on_subscribe callback is invoked after test finishes; the reference to the stack-allocated atomic counter is no longer valid, causing asan failure.
  • I don't understand the intention of this test. The counter is actually unused. Should I re-add it on-heap and then assert a correct value? Couldn't determine from git blame the intention.

@cadedaniel
Deflake gcs_client_test.cc
a686002 
Signed-off-by: Cade Daniel <[email protected]>
@cadedaniel cadedaniel changed the title Deflake gcs_client_test.cc [core] Deflake gcs_client_test.cc Apr 14, 2023
@cadedaniel cadedaniel linked an issue Apr 14, 2023 that may be closed by this pull request
[CI] linux://:gcs_client_test is failing/flaky on master. #34344
Closed
@cadedaniel cadedaniel marked this pull request as ready for review April 14, 2023 22:28
@cadedaniel cadedaniel requested a review from a team as a code owner April 14, 2023 22:28
@fishbone fishbone merged commit 0dafee9 into ray-project:master Apr 17, 2023
@cadedaniel cadedaniel deleted the deflake-gcs-client-test branch April 17, 2023 19:26
justinvyu pushed a commit to justinvyu/ray that referenced this pull request Apr 18, 2023
@cadedaniel @justinvyu
Deflake gcs_client_test.cc (ray-project#34411)
5f2edc6 
Hypothesis is that on_subscribe callback is invoked after test finishes; the reference to the stack-allocated atomic counter is no longer valid, causing asan failure.
@rkooo567
Copy link
Contributor

Screen Shot 2023-04-17 at 5 37 50 PM

hmm unfortunately, this doesn't seem to fix issues

elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@cadedaniel @elliottower
Deflake gcs_client_test.cc (ray-project#34411)
9839f6b 
Hypothesis is that on_subscribe callback is invoked after test finishes; the reference to the stack-allocated atomic counter is no longer valid, causing asan failure.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@cadedaniel @ProjectsByJackHe
Deflake gcs_client_test.cc (ray-project#34411)
b931ce9 
Hypothesis is that on_subscribe callback is invoked after test finishes; the reference to the stack-allocated atomic counter is no longer valid, causing asan failure.

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishbone fishbone fishbone approved these changes

Assignees

@fishbone fishbone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] linux://:gcs_client_test is failing/flaky on master.
3 participants
@cadedaniel @rkooo567 @fishbone