Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[air] Use Ray storage URI as default storage path, if configured [no_early_kickoff] #34470

Merged
merged 7 commits into from
Apr 18, 2023
Merged

[air] Use Ray storage URI as default storage path, if configured [no_early_kickoff] #34470

merged 7 commits into from
Apr 18, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

With this PR, we will use the configured Ray storage URI for syncing Ray AIR results if no other remote storage path is set.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested a review from ericl April 17, 2023 14:29
Kai Fricke added 2 commits April 17, 2023 15:29
revert tuner internal
0cfccaf 
Signed-off-by: Kai Fricke <[email protected]>
[no_early_kickoff] nit
ffca455 
Signed-off-by: Kai Fricke <[email protected]>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 17, 2023
@krfricke krfricke changed the title [air] Use Ray storage URI as default storage path, if configured [air] Use Ray storage URI as default storage path, if configured [no_early_kickoff] Apr 18, 2023
@krfricke krfricke merged commit 45cb8b5 into ray-project:master Apr 18, 2023
@krfricke krfricke deleted the air_ray-storage-path branch April 18, 2023 11:42
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@krfricke @elliottower
[air] Use Ray storage URI as default storage path, if configured [no_…
4589793 
…early_kickoff] (ray-project#34470)

With this PR, we will use the configured Ray storage URI for syncing Ray AIR results if no other remote storage path is set.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@krfricke @ProjectsByJackHe
[air] Use Ray storage URI as default storage path, if configured [no_…
62a6404 
…early_kickoff] (ray-project#34470)

With this PR, we will use the configured Ray storage URI for syncing Ray AIR results if no other remote storage path is set.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krfricke @ericl