-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver logs to Jobs page for submission jobs #34514
Conversation
Signed-off-by: Alan Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to add a refresh button? Until we make it print last N lines & that's probably the best way to use this effectively.
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
|
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
Signed-off-by: Alan Guo <[email protected]>
} else if (driver_info && ipLogMap[driver_info.node_ip_address]) { | ||
return `${ipLogMap[driver_info.node_ip_address]}/`; | ||
} | ||
})(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we need to add another else to catch the case
!driver_agent_http_address || (!driver_info || !ipLogMap[driver_info.node_ip_address])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No in that case, we do not show any logs so the default behavior of return undefined
is what we want.
const host = (() => { | ||
if (driver_agent_http_address) { | ||
return `${driver_agent_http_address}/logs/`; | ||
} else if (driver_info && ipLogMap[driver_info.node_ip_address]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this possible that driver_info.node_ip_address
is undefined or driver_info.node_ip_address
not exists in ipLogMap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no for driver_info.node_ip_address
, yes for the second thing. That's why we check for the value from the dictionary.
@scottsun94 , want to take another look? I think I added the autoscaler row to the job detail page since you last reviewed |
It's hidden for driver jobs because it's not possible to set metadata. For submission jobs, it shows up as a "-" if empty. |
oh. I see. This is the same for driver logs. NVM. Let's get this in first and wait for more info. |
Everything LGTM. Thanks! |
Add driver logs to Jobs page for submission jobs Adds a refresh button to the log viewer to reload the logs. Refactors the log viewer from the logs page into its own component Updates the look and feel of the jobs page to match the new IA style. Adds User-provided metadata to the job detail page. (fixes [Core|Dashboard] Support custom tags for jobs. ray-project#34187 ) Updates the table icon Change "Tasks" to "Tasks/actor overview" Adds Node Count Card next to ray status cards Signed-off-by: elliottower <[email protected]>
Add driver logs to Jobs page for submission jobs Adds a refresh button to the log viewer to reload the logs. Refactors the log viewer from the logs page into its own component Updates the look and feel of the jobs page to match the new IA style. Adds User-provided metadata to the job detail page. (fixes [Core|Dashboard] Support custom tags for jobs. ray-project#34187 ) Updates the table icon Change "Tasks" to "Tasks/actor overview" Adds Node Count Card next to ray status cards Signed-off-by: Jack He <[email protected]>
Add driver logs to Jobs page for submission jobs Adds a refresh button to the log viewer to reload the logs. Refactors the log viewer from the logs page into its own component Updates the look and feel of the jobs page to match the new IA style. Adds User-provided metadata to the job detail page. (fixes [Core|Dashboard] Support custom tags for jobs. ray-project#34187 ) Updates the table icon Change "Tasks" to "Tasks/actor overview" Adds Node Count Card next to ray status cards
Why are these changes needed?
Job detail page
Other job pages (new look and feel)
Jobs user-provided metadata
Autoscaler section
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.