[CI][Core] Set some GCE smoke tests to run on manual frequency #34516
Conversation
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
| smoke_test: | ||
| frequency: manual |
There was a problem hiding this comment.
what does smoke_test mean specifically under this context? why is frequency under smoke_test?
There was a problem hiding this comment.
Oh, I didn't add GCE variance for smoke tests (i.e, I didn't create the gce compute config for smoke tests) since it doesn't provide extra signals.
There was a problem hiding this comment.
The test runner auto-generates smoke tests as they inherit from the default definition. This line override that inheritance to set smoke test frequency to manual ;)
There was a problem hiding this comment.
Just to point out that the smoke test currently cannot run on GCE since there is no gce compute config.
There was a problem hiding this comment.
Ack, this change will stop those broken smoke GCE from running in nightly build
|
w00h00 thanks |
…roject#34516) I noticed some GCE smoke versions are run on nightly. Let's move them to run on manual instead, since we don't want to spend the cost on run them on an automatic cadence yet. --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: elliottower <[email protected]>
…roject#34516) I noticed some GCE smoke versions are run on nightly. Let's move them to run on manual instead, since we don't want to spend the cost on run them on an automatic cadence yet. --------- Signed-off-by: Cuong Nguyen <[email protected]> Signed-off-by: Jack He <[email protected]>
…roject#34516) I noticed some GCE smoke versions are run on nightly. Let's move them to run on manual instead, since we don't want to spend the cost on run them on an automatic cadence yet. --------- Signed-off-by: Cuong Nguyen <[email protected]>
Why are these changes needed?
I noticed some GCE smoke versions are run on nightly. Let's move them to run on manual instead, since we don't want to spend the cost on run them on an automatic cadence yet.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.