Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air] Change doc occurrences of ray.data.Dataset to ray.data.Datastream #34520

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Apr 18, 2023

Why are these changes needed?

We recently renamed Dataset to Datastream - this PR changes occurrences of Dataset in the Ray AIR examples to Datastream. This will also fix currently broken examples that still refer to Dataset when Datastream is imported instead

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke
Copy link
Contributor Author

AIR examples test is passing, merging

@krfricke krfricke merged commit e7e18d6 into ray-project:master Apr 18, 2023
@krfricke krfricke deleted the air/dataset-datastream branch April 18, 2023 12:56
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…am (ray-project#34520)

We recently renamed `Dataset` to `Datastream` - this PR changes occurrences of Dataset in the Ray AIR examples to Datastream. This will also fix currently broken examples that still refer to `Dataset` when `Datastream` is imported instead

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
…am (ray-project#34520)

We recently renamed `Dataset` to `Datastream` - this PR changes occurrences of Dataset in the Ray AIR examples to Datastream. This will also fix currently broken examples that still refer to `Dataset` when `Datastream` is imported instead

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants